Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit test with 304 response #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added unit test with 304 response #166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b189fb
Added unit test with 304 response
Apr 9, 2024
7eba371
Fixing build issue
Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nethttp_request_adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@
func (a *NetHttpRequestAdapter) throwIfFailedResponse(ctx context.Context, response *nethttp.Response, errorMappings abs.ErrorMappings, spanForAttributes trace.Span) error {
ctx, span := otel.GetTracerProvider().Tracer(a.observabilityOptions.GetTracerInstrumentationName()).Start(ctx, "throwIfFailedResponse")
defer span.End()
if response.StatusCode < 400 {
if response.StatusCode < 400 || response.StatusCode == http.StatusNotModified {

Check failure on line 746 in nethttp_request_adapter.go

View workflow job for this annotation

GitHub Actions / build 

undefined: http
return nil
}
spanForAttributes.SetStatus(codes.Error, "received_error_response")
Expand Down
Loading