Added unit test with 304 response #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Any chance you can double check the build issue @Haimantika
The new commit should solve it. |
calebkiage
reviewed
Apr 9, 2024
| @@ -743,7 +743,7 @@ const ErrorBodyFoundAttributeName = "com.microsoft.kiota.error.body_found" | |||
| func (a *NetHttpRequestAdapter) throwIfFailedResponse(ctx context.Context, response *nethttp.Response, errorMappings abs.ErrorMappings, spanForAttributes trace.Span) error { | |||
| ctx, span := otel.GetTracerProvider().Tracer(a.observabilityOptions.GetTracerInstrumentationName()).Start(ctx, "throwIfFailedResponse") | |||
| defer span.End() | |||
| if response.StatusCode < 400 { | |||
| if response.StatusCode < 400 || response.StatusCode == nethttp.StatusNotModified { | |||
There was a problem hiding this comment.
Isn't 304 included in the range of values <400? I don't see why explicitly checking for 304 would change the behavior here?
There was a problem hiding this comment.
Ideally, yes. So should we skip it?
There was a problem hiding this comment.
@Haimantika I think what we should is probably revert this then add a unit test that captures the scenario that is decribed in #163 in this file
There was a problem hiding this comment.
This is helpful! Thanks @andrueastman I will work on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #163