Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check type conversion of nethttp.DefaultTransport to *nethttp.Transport, return DefaultTransport on fail #161

Conversation

steveruckdashel
Copy link
Contributor

fixes #160

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
Can you also add an entry to the changelog (new patch, tomorrow's date, charged)
And bump the version in the user agent handler?
Thanks!

@steveruckdashel
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet merged commit ca399ad into microsoft:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

unchecked type conversion results in panic
2 participants