Return error and status not content is empty #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where 4XX and 5XX responses with no content would return a "content is empty" error instead of information about the status code. Add a regression test for this as well.
ashmrtn
requested review from
andrueastman,
baywet,
zengin,
MIchaelMainer,
peombwa,
calebkiage and
rkodev
as code owners
andrueastman
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thanks for this @ashmrtn
Any chance you update the changelog as well?
|
To provide more context over Andrew's comment:
|
baywet
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where unsuccessful responses with no content would return a "content is empty" error from various serialization libraries instead of information about the status code.
Add a regression test for this as well.