Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): adhere attribute name to otel semver #435

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Strazz1337
Copy link
Contributor

Updates the http span attributes to match with the updated OTEL specification.

closes #344

@Strazz1337 Strazz1337 requested a review from a team as a code owner October 10, 2024 19:13
@Strazz1337
Copy link
Contributor Author

@microsoft-github-policy-service agree

baywet
baywet previously approved these changes Oct 10, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet
Copy link
Member

baywet commented Oct 10, 2024

Can you also add an entry to the changelog (patch, today, changed) and bump the version in the directory file please?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet merged commit 650812d into microsoft:main Oct 11, 2024
7 checks passed
@baywet
Copy link
Member

baywet commented Oct 11, 2024

@Strazz1337 Strazz1337 deleted the fix-adhere-to-otel-spec branch October 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

http - align OTEL http attributes with latest standard
2 participants