-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and remove CPU from epoch computation on active and idle #3920
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alan Jowett <[email protected]>
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit af048fb)Here are some key observations to aid the review process:
|
Add qodo agent
7b60ca4
to
6dfd02b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that what I wrote isn't too annoying.
No, I loved it. I dislike that en-gb and en-us differ like this :-P |
Persistent review updated to latest commit af048fb |
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Co-authored-by: Dave Thaler <[email protected]>
36ae7fe
to
1b357e6
Compare
Signed-off-by: Alan Jowett <[email protected]>
1b357e6
to
0bb37d0
Compare
Signed-off-by: Alan Jowett <[email protected]>
Co-authored-by: Dave Thaler <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
…for-windows into cpu_activation
Signed-off-by: Alan Jowett <[email protected]>
Converting to draft until usersim bug is fixed. |
Description
Restore the changes reverted by 205802b and fix a bug that was causing use after free (the for loop for computing oldest epoch was malformed resulting in a no-op).
Note: This is intentionally three or more commits:
Testing
CI/CD + 24 hour run of api_test.exe (previously failing after 2 hours).
Documentation
Yes, in the files.
Installation
No.