Review requested widget now is customizable

src/GitHubExtension/Widgets/GitHubReviewWidget.cs

@@ -1,70 +1,25 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-using System.Text.Json.Nodes;
-using GitHubExtension.DataManager;
 using GitHubExtension.Helpers;
-using Microsoft.Windows.Widgets.Providers;
 using Octokit;
 
 namespace GitHubExtension.Widgets;
 
 internal sealed class GitHubReviewWidget : GitHubUserWidget
 {
-    public GitHubReviewWidget()
-        : base()
-    {
-        // This widget does not allow customization, so this value will not change.
-        ShowCategory = SearchCategory.PullRequests;
-    }
-
-    public override void RequestContentData()
-    {
-        var request = new SearchIssuesRequest($"review-requested:{UserName}");
-
-        RequestContentData(request);
-    }
+    protected override string DefaultShowCategory => "PullRequests";
 
     protected override string GetTitleIconData()
     {
         return IconLoader.GetIconAsBase64("pulls.png");
     }
 
-    // This widget does not have "ShowCategory" as a variable.
-    // So we override this method to not care about this data.
-    protected override void ResetWidgetInfoFromState()
-    {
-        base.ResetWidgetInfoFromState();
-        ShowCategory = SearchCategory.PullRequests;
-    }
-
-    // Overriding this method because this widget only cares about the account.
-    public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
+    public override void RequestContentData()
     {
-        if (actionInvokedArgs.Verb == "Submit")
-        {
-            var data = actionInvokedArgs.Data;
-            var dataObject = JsonNode.Parse(data);
-
-            if (dataObject == null)
-            {
-                return;
-            }
-
-            DeveloperLoginId = dataObject["account"]?.GetValue<string>() ?? string.Empty;
-            UpdateTitle(dataObject);
-
-            ConfigurationData = data;
+        var request = new SearchIssuesRequest($"review-requested:{UserName}");
 
-            // If we got here during the customization flow, we need to LoadContentData again
-            // so we can show the loading page rather than stale data.
-            LoadContentData();
-            UpdateActivityState();
-        }
-        else
-        {
-            base.OnActionInvoked(actionInvokedArgs);
-        }
+        RequestContentData(request);
     }
 
     public override string GetTemplatePath(WidgetPageState page)

src/GitHubExtension/Widgets/GitHubUserWidget.cs

@@ -19,6 +19,8 @@ internal abstract class GitHubUserWidget : GitHubWidget
 
     protected SearchCategory ShowCategory { get; set; } = SearchCategory.Unknown;
 
+    protected virtual string DefaultShowCategory => string.Empty;
+
     private string _userName = string.Empty;
 
     protected string UserName
@@ -115,7 +117,7 @@ protected override void ResetWidgetInfoFromState()
         try
         {
             dataObject ??= JsonNode.Parse(ConfigurationData);
-            ShowCategory = EnumHelper.StringToSearchCategory(dataObject!["showCategory"]?.GetValue<string>() ?? string.Empty);
+            ShowCategory = EnumHelper.StringToSearchCategory(dataObject!["showCategory"]?.GetValue<string>() ?? DefaultShowCategory);
             DeveloperLoginId = dataObject!["account"]?.GetValue<string>() ?? string.Empty;
             UpdateTitle(dataObject);
         }
@@ -147,7 +149,7 @@ public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
                 return;
             }
 
-            ShowCategory = EnumHelper.StringToSearchCategory(dataObject["showCategory"]?.GetValue<string>() ?? string.Empty);
+            ShowCategory = EnumHelper.StringToSearchCategory(dataObject["showCategory"]?.GetValue<string>() ?? DefaultShowCategory);
             DeveloperLoginId = dataObject["account"]?.GetValue<string>() ?? string.Empty;
             UpdateTitle(dataObject);
 

src/GitHubExtensionServer/Package-Can.appxmanifest

@@ -212,7 +212,7 @@
                       </LightMode>
                     </ThemeResources>
                   </Definition>
-                  <Definition Id="GitHub_Reviews" DisplayName="ms-resource:Widget_DisplayName_Reviews" Description="ms-resource:Widget_Description_Reviews" IsCustomizable="false">
+                  <Definition Id="GitHub_Reviews" DisplayName="ms-resource:Widget_DisplayName_Reviews" Description="ms-resource:Widget_Description_Reviews" IsCustomizable="true">
                     <Capabilities>
                       <Capability>
                         <Size Name="medium" />

src/GitHubExtensionServer/Package-Dev.appxmanifest

@@ -212,7 +212,7 @@
                       </LightMode>
                     </ThemeResources>
                   </Definition>
-                  <Definition Id="GitHub_Reviews" DisplayName="ms-resource:Widget_DisplayName_Reviews" Description="ms-resource:Widget_Description_Reviews" IsCustomizable="false">
+                  <Definition Id="GitHub_Reviews" DisplayName="ms-resource:Widget_DisplayName_Reviews" Description="ms-resource:Widget_Description_Reviews" IsCustomizable="true">
                     <Capabilities>
                       <Capability>
                         <Size Name="medium" />

src/GitHubExtensionServer/Package.appxmanifest

@@ -212,7 +212,7 @@
                       </LightMode>
                     </ThemeResources>
                   </Definition>
-                  <Definition Id="GitHub_Reviews" DisplayName="ms-resource:Widget_DisplayName_Reviews" Description="ms-resource:Widget_Description_Reviews" IsCustomizable="false">
+                  <Definition Id="GitHub_Reviews" DisplayName="ms-resource:Widget_DisplayName_Reviews" Description="ms-resource:Widget_Description_Reviews" IsCustomizable="true">
                     <Capabilities>
                       <Capability>
                         <Size Name="medium" />