Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected spelling (and casing) of error messages #259

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Corrected spelling (and casing) of error messages #259

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa475b
Corrected spelling (and casing) of error messages
ElmarJ Nov 4, 2023
ff93189
Additional corrections to exception messages
ElmarJ Nov 6, 2023
0696454
Merge branch 'main' into patch-correct-spelling-of-error-messages
krschau Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/GitHubExtension/Providers/RepositoryProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,28 +223,28 @@ public IAsyncOperation<ProviderOperationResult> CloneRepositoryAsync(IRepository
}
catch (LibGit2Sharp.RecurseSubmodulesException recurseException)
{
Providers.Log.Logger()?.ReportError("DevHomeRepository", "Could not clone all sub modules", recurseException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, recurseException, "Could not clone all modules", recurseException.Message);
Providers.Log.Logger()?.ReportError("DevHomeRepository", "Could not clone all submodules.", recurseException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, recurseException, "Could not clone all submodules.", recurseException.Message);
}
catch (LibGit2Sharp.UserCancelledException userCancelledException)
{
Providers.Log.Logger()?.ReportError("DevHomeRepository", "The user stoped the clone operation", userCancelledException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, userCancelledException, "User cancalled the operation", userCancelledException.Message);
Providers.Log.Logger()?.ReportError("DevHomeRepository", "The user stopped the clone operation.", userCancelledException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, userCancelledException, "User cancelled the clone operation.", userCancelledException.Message);
}
catch (LibGit2Sharp.NameConflictException nameConflictException)
{
Providers.Log.Logger()?.ReportError("DevHomeRepository", nameConflictException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, nameConflictException, "The location exists and is non-empty", nameConflictException.Message);
return new ProviderOperationResult(ProviderOperationStatus.Failure, nameConflictException, "The destination location is non-empty.", nameConflictException.Message);
}
catch (LibGit2Sharp.LibGit2SharpException libGitTwoException)
{
Providers.Log.Logger()?.ReportError("DevHomeRepository", $"Either no logged in account has access to this repo, or the repo can't be found", libGitTwoException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LigGit2 threw an exception", "LibGit2 Threw an exception");
Providers.Log.Logger()?.ReportError("DevHomeRepository", $"Either no logged in account has access to this repository, or the repository can't be found.", libGitTwoException);
return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2 library threw an exception.", "LibGit2 library threw an exception.");
}
catch (Exception e)
{
Providers.Log.Logger()?.ReportError("DevHomeRepository", "Could not clone the repository", e);
return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repo", "something happened when cloning the repo");
Providers.Log.Logger()?.ReportError("DevHomeRepository", "Could not clone the repository.", e);
return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository.", "Something happened when cloning the repository.");
}

return new ProviderOperationResult(ProviderOperationStatus.Success, new ArgumentException("Nothing wrong"), "Nothing wrong", "Nothing wrong");
Expand Down