After editing widget, show loading page instead of stale data (#264)

* Show loading page instead of stale data after customization * force immedaite data update request
microsoft · Nov 8, 2023 · 865d4bc · 865d4bc
1 parent 9dc9efe
commit 865d4bc
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/GitHubExtension/Widgets/GitHubAssignedWidget.cs b/src/GitHubExtension/Widgets/GitHubAssignedWidget.cs
@@ -126,6 +126,10 @@ public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
             if (dataObject != null && dataObject.ShowCategory != null)
             {
                 ShowCategory = EnumHelper.StringToSearchCategory(dataObject.ShowCategory);
+
+                // If we got here during the customization flow, we need to LoadContentData again
+                // so we can show the loading page rather than stale data.
+                LoadContentData();
                 UpdateActivityState();
             }
         }

diff --git a/src/GitHubExtension/Widgets/GitHubMentionedInWidget.cs b/src/GitHubExtension/Widgets/GitHubMentionedInWidget.cs
@@ -146,6 +146,10 @@ public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
             if (dataObject != null && dataObject.ShowCategory != null)
             {
                 ShowCategory = EnumHelper.StringToSearchCategory(dataObject.ShowCategory);
+
+                // If we got here during the customization flow, we need to LoadContentData again
+                // so we can show the loading page rather than stale data.
+                LoadContentData();
                 UpdateActivityState();
             }
         }

diff --git a/src/GitHubExtension/Widgets/GitHubWidget.cs b/src/GitHubExtension/Widgets/GitHubWidget.cs
@@ -140,7 +140,21 @@ public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
                 break;
 
             case WidgetAction.Save:
+                // Set loading page while we swap out the data.
+                Page = WidgetPageState.Loading;
+
+                // It might take some time to get the new data, so
+                // set data state to "unknown" so that loading page is shown.
+                DataState = WidgetDataState.Unknown;
+                UpdateWidget();
+
                 SavedRepositoryUrl = string.Empty;
+                LoadContentData();
+
+                // Reset the throttle time and force an immediate data update request.
+                LastUpdated = DateTime.MinValue;
+                RequestContentData();
+
                 SetActive();
                 break;