Fix warnings in natvis project #1463
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmachaj
approved these changes
Dec 12, 2024
| @@ -4,7 +4,10 @@ | |||
| #define NOMINMAX | |||
|
|
|||
| #include <windows.h> | |||
| #pragma warning(push) | |||
| #pragma warning(disable : 4471) | |||
| #include <vsdebugeng.h> | |||
There was a problem hiding this comment.
Is there a way to pull a newer version of this nuget package? I tried specifying the latest but couldn't nuget pull after that.
There was a problem hiding this comment.
I've tried before, and there's been some weirdness. But I've been making some visualizer improvements and hope to do some updating as part of that work! For now, though, I'm a big fan of keeping PRs tightly scoped when possible. :) My main goal here is to eliminate the warning spew that's currently happening in the repo so we can get everything resolved and prevent "warning creep" going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a slew of compilation warnings in the natvis project. This addresses them.
Most are coming from a the
<vsdebugeng.h>header in theMicrosoft.VSSDK.Debugger.VSDebugEng.16.0.2012201-previewpackage.But there were a few where a global variable named
dbwas getting hidden by a localdbin a different scope. Let's just give the global a more unique name for now.