Add nuget.config for Secure Supply Chain #1403
Closed
+37
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Supply Chain Analysis flagged this repository as having some csproj files, but no nuget.config. I'm adding a nuget.config that is mostly boilerplate, but declares a single PackageSource, CppWinRT's internal Azure Artifacts feed, which has an upstream to nuget.org.
I'd like to avoid breaking local builds for non-MSFT folks, but NuGet feeds isn't exactly an area that I've dabbled with. If there's a non-MSFT person, or anybody with a machine that can't authenticate to https://microsoft.pkgs.visualstudio.com/_packaging/CppWinRT/nuget/v3/index.json, I'm interested to hear if you're able to build the csproj files in this repo.
While I was looking at NuGet stuff, I decided to modify the PR pipeline default to not publish to the internal feed. This can still be overridden if the user chooses.