Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unnecessary webdriverio/spectron references #5342

Merged
merged 5 commits into from
Apr 13, 2022

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Apr 8, 2022

Details

This PR removes some unnecessary code and an unnecessary dependency on webdriverio that became obsolete when we switched the unified e2e tests from spectron to playwright. Per the comment in dependabot.yml, we were only using webdriverio for typings shared between it and spectron; it isn't required anymore.

I also removed a few other lingering bits of dead code related to Spectron while I was here (eg, a bunch of timeout constants that we stopped using with the move to playwright).

Motivation

Originally, this was part of a PR to resolve a CG alert against the async package. The non-dev dependencies on async were resolved by other PRs and the specific CG alert in question isn't applicable to dev dependencies, so it's no longer necessary to do any further resolutions for async; however, I kept this bit of the PR since removing the unnecessary code still seemed nice.

Context

n/a

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner April 8, 2022 22:54
@dbjorge dbjorge changed the title chore(deps): update async dep to 3.2.3, and remove unneeded cases chore: clean up unnecessary webdriverio/spectron references Apr 8, 2022
@dbjorge dbjorge merged commit 7360bd9 into microsoft:main Apr 13, 2022
@dbjorge dbjorge deleted the update-async-dep branch April 13, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants