Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivy container scans #59

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

haithamshahin333
Copy link
Contributor

Describe your Changes

Issue ticket number and link if relevant

Checklist before requesting a review

  • I have performed a self-review of my code and documentation
  • I have updated the README to denote my solution/training/whitepaper
  • I have identified which clouds this can run (Azure Cloud / Azure Government)

@timothymeyers
Copy link
Contributor

Looks good @haithamshahin333. I noticed that the container topic area doesn't have a README.md file. Should it?

Copy link
Contributor

@timothymeyers timothymeyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment

@haithamshahin333
Copy link
Contributor Author

Thanks @timothymeyers for reviewing! When the repo was setup we put the README's in the empty folders really as placeholders so that the folder structure would exist (since the empty folders otherwise could not be committed).

I went ahead and removed for the Containers folder as well as Container/Solutions since now that there is content there, that placeholder shouldn't be needed, and this way when we're adding content we can add just to one README on our main page.

A good callout though that as we add content to currently empty folders, we should remove the placeholders to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants