Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed tune.report import for ray>=2 #1392

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

drwillcharles
Copy link

Why are these changes needed?

When using ray>=2, there is an import error for tune.report.

AttributeError: module 'ray.tune' has no attribute 'report'

I used the Ray migration guide to update this and use the new report function if the ray version is not 1.x .

I see that in the FLAML codebase there are already a few workarounds like this so I think I can do something similar without needing a full migration to Ray 2.x

Related issue number

Related to #874 - although I still think a full migration to Ray>=2 is needed in the future.

Checks

@drwillcharles
Copy link
Author

@microsoft-github-policy-service agree company="Evotec"

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @drwillcharles , for the PR!

@thinkall
Copy link
Collaborator

Hi @drwillcharles , could you check the test errors? Looks like the change will lead to test timeout issue. Thanks.

@drwillcharles
Copy link
Author

It appears the test _test_hf_data() on test_gpu.py gets stuck in a loop because of an error in Ray. Strangely - this test is not even run because of the naming convention. (_test_hf_data() instead of test_hf_data()).

I have loosened the pydantic dependency and hope this solves the issue.

@drwillcharles
Copy link
Author

OpenML is currently down so a lot of tests are getting connection errors. Will wait until this is back online before I resume development.

From the tests that have run successfully, it appears there are still some environment issues to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants