-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disambiguate UpdateTileMappings function usage #802
base: master
Are you sure you want to change the base?
Conversation
hadalhw17
commented
Nov 8, 2022
- According to official docs(https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12commandqueue-updatetilemappings?redirectedfrom=MSDN), UpdateTileMappings is only taking a pointer to a single heap(allowing multiple offsets into this heap, but not multiple heaps). The sample is iterating over multiple heaps and tries to map tiles to them in a single UpdateTileMappings call. While this doesn't break the functionality of the sample, in a real world applications with more complicated heap usage patterns, this wouldn't work.
- According to official docs, UpdateTileMappings is only taking a pointer to a single heap(allowing multiple offsets into this heap, but not multiple heaps). While this doesn't break the functionality of the sample, this would't work in real applications
@hadalhw17 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |