D3D12RaytracingRealTimeDenoisedAmbientOcclusion - large per frame upload #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue mask, write mask is 7 and store value mask is 0.
…. The array was previously uploaded to GPU on every frame and since the array is quite large (87031808 bytes) it caused unnecessary CPU overhead (8ms of CPU time on i7 4790K 4.4GHz 32GB RAM 2070 RTX). On simpler scenes this was main bottleneck i.e. in the default scene with grass disabled (#define RENDER_GRASS_GEOMETRY 0) framerate tripled (~100 to ~300fps) with GPU timings unaffected. TODO: - The array is unnecessarily triple-buffered and has to be uploaded three times on consecutive frames. Only single upload is required since the content is unchanged. - In order to reduce size precision of the array can be reduced to half float or even 8bit SNORM.
|
|
MAXRAYUM3
approved these changes
Nov 17, 2023
MAXRAYUM3
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for #681.
m_hemisphereSamplesGPUBuffer.CopyStagingToGpu(frameIndex) is executed three times (back buffer count) only when AO samples are recreated.
The array was previously uploaded to GPU on every frame and since the array is quite large (87031808 bytes) it caused unnecessary CPU overhead (8ms of CPU time on i7 4790K 4.4GHz 32GB RAM 2070 RTX). On simpler scenes this was main bottleneck i.e. in the default scene with grass disabled (#define RENDER_GRASS_GEOMETRY 0) framerate tripled (~100 to ~300fps) with GPU timings unaffected.
TODO: