Update cron documentation to include Spring formatting #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and clarify the format of the cron expression.
lbroudoux
requested changes
Sep 8, 2021
| @@ -347,7 +347,7 @@ <h3 id="creating-a-new-scheduled-import">Creating a new scheduled import</h3> | |||
| <p><img src="/images/importer-step3.png" alt="importer-step3"></p> | |||
| <p>On first time creation the Job is automatically <code>Scanned</code> and <code>Imported</code>.</p> | |||
| <h3 id="configure-scheduling-interval">Configure scheduling interval</h3> | |||
| <p>The scheduling interval can be globally configured for all the Jobs. It is a global setting and not a per-Job one. This is achieved through the <code>services.update.interval</code> property in the <code>application.properties</code> configuration file that takes the value of <code>SERVICES_UPDATE_INTERVAL</code> environment variable. The value should be set to a valid <a href="https://en.wikipedia.org/wiki/Cron#CRON_expression">CRON expression</a> ; default is every 2 hours.</p> | |||
| <p>The scheduling interval can be globally configured for all the Jobs. It is a global setting and not a per-Job one. This is achieved through the <code>services.update.interval</code> property in the <code>application.properties</code> configuration file that takes the value of <code>SERVICES_UPDATE_INTERVAL</code> environment variable. The value should be set to a valid <a href="https://docs.oracle.com/cd/E12058_01/doc/doc.1014/e12030/cron_expressions.htm">CRON expression in Spring format</a> ; default is every 2 hours.</p> | |||
There was a problem hiding this comment.
I'm not a big fan of having a link to Oracle documentation... you were mentioning Spring documentation in your comment. I've found this link to be helpful: https://spring.io/blog/2020/11/10/new-in-spring-5-3-improved-cron-expressions
What do you think?
|
Thanks for the PR and sorry for little delay. Also, sorry to bother you but this is the wrong repo... We use https://github.com/microcks/microcks.io that is Markdown content to generate and commit automatically on this repo. Would you mind reapplying to this repo? Namely on the https://github.com/microcks/microcks.io/blob/master/content/documentation/using/importers.md file. I know it could be boring and I can do for you if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely removed the Wikipedia link as that specifically discusses the Unix format and will cause confusion. Instead, I swapped it with a link to the Spring documentation.