Warn users when using V2 API features with micro:bit V1 #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
microbit-robert
force-pushed
the
version-warning
branch
from
a3f6454
to
efcb956
Compare
| @@ -2430,7 +2448,7 @@ | |||
| "webusb-error-clear-connect-description-2": [ | |||
| { | |||
| "type": 0, | |||
| "value": "Close any other pages or tabs that may be using WebUSB (e.g. MakeCode, Python Editor), or unplug and replug the micro:bit before trying again." | |||
| "value": "Close any other tabs that may be using WebUSB (e.g. MakeCode, Python Editor), or unplug and replug the micro:bit before trying again." | |||
There was a problem hiding this comment.
Puzzled about this. When did this change and why wasn't this file updated then?
There was a problem hiding this comment.
This change happens on main too.
I think it was accidentally included in 9bfff59 because we made a change to ui.en.json then reverted it but failed to revert the updated src/messages file. So this revert is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Pyright to included the changes from microbit-foundation/pyright#35