-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling for WebUSB issues #1164
Conversation
Remove unused text as firmware update handled specially by its own dialog
Preview build will be at |
Fix remaining invalid DOM nesting issue.
Fallback error requesting reconnect
Failed to claim interfaceShould we change the language to not use process and maybe avoid the repetition? For example:
Is app the best option? "application"? I think "program" isn't quite right especially in the context of a micro:bit editor and process is too techy. Should this have the full replug advice + video? Leaning towards no as the best correction is likely to close the other tab. Connection timeoutI think this should have the replug advice + video. |
lang/ui.en.json
Outdated
@@ -1116,29 +1116,21 @@ | |||
"description": "Part of WebUSB error message" | |||
}, | |||
"webusb-error-clear-connect-description-2": { | |||
"defaultMessage": "Close any other tabs that may be using WebUSB (e.g. MakeCode, Python Editor), or unplug and replug the micro:bit before trying again.", | |||
"defaultMessage": "Close any other tabs that may be using WebUSB (e.g. MakeCode, Python Editor, machine learning tool), or unplug and replug the micro:bit before trying again.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that we want to add the ML tool here but one to confirm on Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still unresolved, but I've simplified this back to being just MakeCode and the Python Editor for now.
Sure, I will update the video when I get a moment. Is it okay to swap the assets out at that point? How disruptive will it be if dimensions change slightly, etc? I will also make sure '1' fades and '2' appears at the same time, as that was bothering me. Any other video feedback?
That language sounds better. To be even more helpful for the user, could we include favicon hints for each?
I think conventionally it would be a 'page' right? Another "Another page or browser tab is connected to this micro:bit" (I think even web apps are still web pages?)
I agree no. I think it's common you need to find that other tab. Though I don't know when it's MakeCode or not. I think it's when you have multiple windows and MakeCode is the frontmost tab in one of them?
Agree |
Given that we've said pages/tabs in the title (below in this file, above in the UI!) it's tempting to reduce the translation churn by reinstating this.
Show dialogs with updated and more user friendly text and graphics instead of a toast notification.
Continue to use existing translations until new text has been translated.
See https://microbit-global.monday.com/boards/1125389526/views/244984/pulses/1434828425 (private)