Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spi:read() second argument #105

Merged
merged 1 commit into from
May 14, 2024
Merged

Add spi:read() second argument #105

merged 1 commit into from
May 14, 2024

Conversation

microbit-grace
Copy link
Contributor

@microbit-grace microbit-grace commented May 13, 2024 •
edited
Loading

@microbit-grace microbit-grace mentioned this pull request May 13, 2024
Merged
@microbit-grace
Copy link
Contributor Author

microbit-foundation/python-editor-v3#1179 for previewing

microbit-matt-hillsdon
microbit-matt-hillsdon approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-grace microbit-grace merged commit d295918 into main May 14, 2024
1 check passed
@microbit-grace microbit-grace deleted the add-spi-read-arg branch May 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-matt-hillsdon microbit-matt-hillsdon microbit-matt-hillsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microbit-grace @microbit-matt-hillsdon