Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak pairing micro:bit wording and adding a step for pin #57

Merged
merged 14 commits into from
May 14, 2024

Conversation

microbit-grace
Copy link
Collaborator

@microbit-grace microbit-grace commented Apr 10, 2024

Task: https://microbit-global.monday.com/boards/1469823673/pulses/1459857054

  • Added enter pin if needed instruction step to pairing flow
  • Remove 30 sec warning text
  • Tweaked searching for micro:bit text

Preview of added step in pairing flow
73078A95-922A-4673-B810-4A5D57638FF1

@microbit-grace microbit-grace changed the title Tweak searching micro:bit wording [WIP] Tweak pairing micro:bit wording Apr 11, 2024
@microbit-grace
Copy link
Collaborator Author

microbit-grace commented Apr 11, 2024

Thanks @martinwork for the feedback re removing the 30 secs warning, Lucy has agreed with you and I have removed it. She also made some new comments in the paper doc link regarding the text while "Searching for micro:bit" part. I have made the corresponding changes. I think it relies heavily on the press-button-A-to-see-pin instruction to be shown long enough for the users to see, which I wonder whether would be an issue. What do you think? Please feel free to add the comments directly on the paper doc. Thank you!

@microbit-grace microbit-grace marked this pull request as ready for review May 10, 2024 12:33
@microbit-grace microbit-grace changed the title [WIP] Tweak pairing micro:bit wording Tweak pairing micro:bit wording and adding a step for pin May 10, 2024
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes seem fine.
Worth confirming with Lucy we're happy with the emphasis that having the GIF before the "if you're asked" text gives to pressing button A (given few folks will encounter it).

I had a bit of a 4 dialog pairing disaster but that also happens for me on main.

- Update title to say "If asked for a PIN"
- Add "Tap Next to pair" text
- Update micro:bit image to the "Let's do it" one
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-grace microbit-grace merged commit 30ac80f into main May 14, 2024
1 check passed
@microbit-grace microbit-grace deleted the tweak-searching-microbit-copy branch May 14, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants