-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak pairing micro:bit wording and adding a step for pin #57
Conversation
Thanks @martinwork for the feedback re removing the 30 secs warning, Lucy has agreed with you and I have removed it. She also made some new comments in the paper doc link regarding the text while "Searching for micro:bit" part. I have made the corresponding changes. I think it relies heavily on the press-button-A-to-see-pin instruction to be shown long enough for the users to see, which I wonder whether would be an issue. What do you think? Please feel free to add the comments directly on the paper doc. Thank you! |
…t-android into tweak-searching-microbit-copy
so that it doesn't change gif or text when device is found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI changes seem fine.
Worth confirming with Lucy we're happy with the emphasis that having the GIF before the "if you're asked" text gives to pressing button A (given few folks will encounter it).
I had a bit of a 4 dialog pairing disaster but that also happens for me on main.
- Update title to say "If asked for a PIN" - Add "Tap Next to pair" text - Update micro:bit image to the "Let's do it" one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task: https://microbit-global.monday.com/boards/1469823673/pulses/1459857054
Preview of added step in pairing flow