New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added jgi_portal_study_identifiers slot and example data #1043

Merged

turbomam merged 2 commits into main from issue-1041-jgi-port-study-id

Jul 11, 2023

Member

turbomam commented Jul 11, 2023

jgi_portal_identifiers isn't attached to anything; make a jgi_portal_study_identifiers and mix in jgi_portal_identifiers #1041


          added jgi_portal_study_identifiers slot...

5fceff2

and example data #1041

turbomam requested a review from aclum

July 11, 2023 22:18

aclum reviewed

View reviewed changes

Contributor

aclum left a comment

Only suggestion is to make the pattern match what bioregistry has so \d+$ instead of ^jgi.proposal:[a-zA-Z0-9_][a-zA-Z0-9_-/.,]*$


          digits only jgi_portal_study_identifiers

16fe52c

aclum approved these changes

View reviewed changes

turbomam merged commit d581442 into main

2 checks passed

turbomam deleted the issue-1041-jgi-port-study-id branch

August 30, 2023 18:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet