Feat MGet #5
Merged
Feat MGet #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 90.08% 90.37% +0.29%
==========================================
Files 3 3
Lines 474 582 +108
==========================================
+ Hits 427 526 +99
- Misses 35 41 +6
- Partials 12 15 +3 ☔ View full report in Codecov by Sentry. |
ikenchina
reviewed
Mar 6, 2024
| val, err := strCmd.Result() | ||
| if err != nil && !errors.Is(err, r.Nil()) { | ||
| logger.Error("MGet#strCmd(%s) error(%v)", keyIdxMap[idx], err) | ||
| } else if len(val) > 0 { |
There was a problem hiding this comment.
Pipeline模式下返回结果，当key不存在，返回的val就是空（""），而不是err=redis.Nil。所以，这里如果val=""，作miss处理（但下次查不会穿透）。因此，业务上设置key的value=""，在MGet场景该key会miss。
remote/goredisv8adapter.go
Outdated
| func (r *GoRedisV8Adaptor) MGet(ctx context.Context, keys ...string) (map[string]any, error) { | ||
| pipeline := r.client.Pipeline() | ||
| keyIdxMap := make(map[int]string, len(keys)) | ||
| ret := make(map[string]any) |
cache.go
Outdated
| c.statsHandler.IncrQueryFail(err) | ||
| logger.Error("MGet#fn(%s) error(%v)", util.JoinAny(",", ids), err) | ||
| } else { | ||
| placeholderValues := make(map[string]any) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to support the function of batch ID querying cache entities. Golang's generics can support this function very conveniently.