Ddev local setup integration for BE and FE site. #434
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonvir249
force-pushed
the
ddev-integration
branch
from
415e8f1
to
8c40738
Compare
sonvir249
changed the title
mglaman
reviewed
Jun 5, 2024
Comment on lines
+8
to
+11
| if ! command -v composer >/dev/null; then | ||
| echo "composer is not available. You may need to install 'composer'" | ||
| exit 1 | ||
| fi |
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
|
|
|||
| #ddev-generated | |||
Comment on lines
+20
to
+22
| hooks: | ||
| post-start: | ||
| - exec: yarn install |
There was a problem hiding this comment.
We should move this to setup, or also have composer install here I suppose
Comment on lines
+23
to
+26
| web_extra_daemons: | ||
| - name: http | ||
| command: "yarn frontend-start" | ||
| directory: /var/www/html |
There was a problem hiding this comment.
I'd had issues with this, where it runs before dependencies have installed. I'm pretty sure this starts up before post-start hook executes.
Comment on lines
+19
to
+27
| 1. Configure frontend app. | ||
| - Create `.env.local` in frontend directory | ||
| - Add following environment variables | ||
|
|
||
| ``` | ||
| REACT_APP_API_BASE_URL=https://contribkanban.com.ddev.site | ||
| PORT=4000 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We can add REACT_APP_API_BASE_URL to the DDEV config yaml web environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things covered
trim()deprecation warning.ddev setupto setup project locally.