Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When test throws an exception, stacktrace shown in dap repl is truncated #737

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

michalchabowski
Copy link
Contributor

@michalchabowski michalchabowski commented Jan 9, 2025

basic fix of #736

@vishal423 Could you please look at it as well? It mainly involves your changes.
I have to admit, that I don't get every line here. I wouldn't like to break something.

@mfussenegger @vishal423 I'd like to thank you for your work! I really appreciate it.

@vishal423
Copy link
Contributor

@michalchabowski, thanks for raising the issue with reproducible steps. I will take a look into it by today evening

Copy link
Contributor

@vishal423 vishal423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me

@mfussenegger mfussenegger merged commit 5b07947 into mfussenegger:master Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants