Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48 split reading into init and separate read call #53

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

48 split reading into init and separate read call #53

wants to merge 9 commits into from

Conversation

jgriesfeller
Copy link
Member

changes needed to not read on init anymore

@jgriesfeller jgriesfeller linked an issue Oct 29, 2024 that may be closed by this pull request
split reading into init and separate read call #48
Open
@jgriesfeller jgriesfeller marked this pull request as draft October 29, 2024 12:57
@jgriesfeller jgriesfeller marked this pull request as ready for review October 30, 2024 14:09
heikoklein
heikoklein reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user point of view, I don't understand what the read function does and why it is required. Let's discuss in person

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heikoklein heikoklein heikoklein left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split reading into init and separate read call
2 participants
@jgriesfeller @heikoklein