Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code adaptation to use ncep global data #25

Merged
merged 3 commits into from
Oct 30, 2024
Merged

code adaptation to use ncep global data #25

merged 3 commits into from
Oct 30, 2024

Conversation

mortenwh
Copy link
Collaborator

Summary:

Related issue:

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, be pragmatic..

@mortenwh mortenwh linked an issue Oct 30, 2024 that may be closed by this pull request
@mortenwh mortenwh merged commit 62e3160 into main Oct 30, 2024
7 checks passed
@mortenwh mortenwh deleted the adapt2ncep branch October 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add use of ncep/gfs
2 participants