Issue116 access constraints #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steingod
reviewed
Oct 29, 2020
There was a problem hiding this comment.
On the line breaks, that is preference issue which I won't dig into (is solved different ways). The rdf:about issue is important but not sure we have the solution here either. I would really like to see this implemented in a triple store. I know @ferrighi was looking at this (different approaches) and think we should follow up on that. In essence, modifications are fine with me, but think we need to follow up on several issues afterwards.
|
Ok - I'll proceed to look through things. I'm adding the thesauri to https://github.com/nansencenter/py-thesaurus-interface now. If you agree about these changes, I can update the other files as well. Otherwise, it can wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #116 (if I have understood correctly...)