Upgrade Reagent #198
Open
Upgrade Reagent #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions of React, in order to obtain the DOM element of a component, the use of refs is recommended: https://react.dev/reference/react-dom/findDOMNode#alternatives `vega` component uses this function, which in recent versions of Reagent is deprecated, so the component is adjusted to use `ref`.
In the last version of React (18), ReactDOM.render is no longer supported. Uses `create-root` (recently provided by Reagent) on `app.cljs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of Reagent is 1.2.0, so I bring oz up to date (required in a project I'm currently working on).
Two "important" changes have emerged:
reagent.dom/dom-nodeis now deprecated, as React introduced the use of refs to obtain the DOM node of the components. Adjustments are based on:https://github.com/reagent-project/reagent/blob/master/doc/FAQ/UsingRefs.md
In React 18,
ReactDOM.renderis no longer supported. So I adjustapp.cljsfollowing the next example:https://stackoverflow.com/a/71710646