Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust README instructions with community feedback #21

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Sep 5, 2024

Committer Notes

This PR includes changes to address feedback from community members in #16 and follow-on impressions in a FedRAMP Implementers meeting. If reviewed, approved, and merged, closes #16.

The two keys goals:

  • Reorder the README content for consuming users over developers locally building the tool
  • Add more clear guidance on how to use Maven to download the zip file.
  • Add docs on how to configure the PATH make the tool readily usable This was already done, I missed it on initial review of extant docs.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@aj-stein-gsa aj-stein-gsa changed the base branch from main to develop September 5, 2024 04:15
@aj-stein-gsa aj-stein-gsa marked this pull request as ready for review September 5, 2024 05:02
Since we will presumably have more people using
the pre-built version than locally building the
tool to add features and fix bugs, we should put
this information earlier in the README.
This commit adds more information on quickly and
effectively using Maven. Also, I added ` ```sh`
fences to code blocks for shell commands. I also
added example of adding to shell configuration
files.
@david-waltermire david-waltermire force-pushed the 16-clarify-readme-instructions branch from 7e79016 to 13c6ae1 Compare September 14, 2024 04:08
@david-waltermire david-waltermire merged commit c106179 into metaschema-framework:develop Sep 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants