add verified creator umi tests for update metadata #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danenbm
requested changes
Jan 23, 2024
Comment on lines
+653
to
+656
| metadata: { | ||
| ...metadata, | ||
| ...updateArgs, | ||
| }, |
| updateArgs, | ||
| }).sendAndConfirm(umi); | ||
|
|
||
| await t.throwsAsync(promise, { name: 'PublicKeyMismatch' }); |
There was a problem hiding this comment.
This test should be failing for 6039: CreatorDidNotUnverify
| root: getCurrentRoot(merkleTreeAccount.tree), | ||
| nonce: leafIndex, | ||
| index: leafIndex, | ||
| currentMetadata: metadata, |
There was a problem hiding this comment.
This metadata needs to be updated after the verifyCreator call.
| root: getCurrentRoot(merkleTreeAccount.tree), | ||
| nonce: leafIndex, | ||
| index: leafIndex, | ||
| currentMetadata: metadata, |
There was a problem hiding this comment.
This metadata needs to be updated after the verifyCreator call.
nicholasoxford
pushed a commit
to Primitives-xyz/primitives-protocol
that referenced
this pull request
Jan 16, 2025
…an/more-update-tests add verified creator umi tests for update metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.