Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK helper to choose compression programs #117

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add SDK helper to choose compression programs #117

merged 2 commits into from
Oct 30, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Oct 30, 2024 •
edited
Loading

Notes

  • If helper is not used, Umi SDK defaults to SPL programs.
  • If helper is used, it chooses based on genesis blockhash.

Testing

  • Running tests on local validator pass and is equivalent to running on another SVM because the genesis blockhash doesn't match a known Solana cluster.
  • Modified code and ran transfer test on Eclipse devnet and Eclipse mainnet-beta and in both cases it chose MPL programs and worked as expected.
  • Modified code and ran transfer test on Solana devnet and Solana mainnet-beta and in both cases it chose SPL programs and worked as expected.

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-bubblegum-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:14pm

@danenbm danenbm marked this pull request as ready for review October 30, 2024 22:10
blockiosaurus
blockiosaurus approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like this approach.

@danenbm danenbm merged commit 36dfe2c into svm Oct 30, 2024
11 checks passed
@danenbm danenbm deleted the danenbm/simple-sdk-helper branch October 30, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockiosaurus blockiosaurus blockiosaurus approved these changes

@nhanphan nhanphan Awaiting requested review from nhanphan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danenbm @blockiosaurus