Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!(python): drop Python 3.7 support and mark some arguments as positional-only #162

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added cxx Something related to the CXX source code py Something related to the Python source code dependencies Pull requests that update a dependency file labels Oct 8, 2024
@XuehaiPan XuehaiPan self-assigned this Oct 8, 2024
@XuehaiPan XuehaiPan force-pushed the drop-py37 branch 2 times, most recently from 31b074e to 1a7f39f Compare October 8, 2024 17:23
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0e4f713) to head (ae89038).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1280      1253   -27     
=========================================
- Hits          1280      1253   -27     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XuehaiPan XuehaiPan force-pushed the drop-py37 branch 3 times, most recently from 29d913a to 2efeb71 Compare October 21, 2024 13:23
@XuehaiPan XuehaiPan force-pushed the drop-py37 branch 3 times, most recently from b0d618f to b5990e3 Compare October 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code dependencies Pull requests that update a dependency file py Something related to the Python source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant