Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT MANUSCRIPT for REVIEW #30

Merged
merged 338 commits into from
Mar 31, 2023
Merged

DRAFT MANUSCRIPT for REVIEW #30

merged 338 commits into from
Mar 31, 2023

Conversation

egouldo
Copy link
Member

@egouldo egouldo commented Nov 7, 2022

Hi All,

This PR contains the latest version of the aggreCAT manuscript, for your review.

To view the fully rendered PDF, checkout vignettes/aggreCAT.pdf.

If you want to test any parts of the package, make sure to rebuild on this branch, I've made some changes to the function documentation and the vignette engine so that the PDF can be included as a vignette.

Please make suggestions to the raw manuscript inst/ms/aggreCAT.qmd using the PR suggestions functionality, https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request. OR, feel free to mark-up the PDF and send it to me via email.

There are a bunch of formatting problems I'm having with LaTeX, e.g. LONG author lists, and I'll get to them. But if you could focus first on the content + structure + examples, that would be great.

@egouldo egouldo added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 7, 2022
@egouldo egouldo added this to the manuscript draft milestone Nov 7, 2022
@egouldo egouldo self-assigned this Nov 7, 2022
@Doi90
Copy link
Contributor

Doi90 commented Nov 7, 2022

🎉🎉🎉🎉🎉

This is a big milestone, @egouldo! Well done.

I'll try to turn a review around by the start of next week.

@psychtek
Copy link
Collaborator

psychtek commented Nov 7, 2022

MAMMOTH EFFORT!! 🥳 🍾

inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
inst/ms/aggreCAT.qmd Outdated Show resolved Hide resolved
egouldo added 27 commits March 31, 2023 12:32
Merge branch 'ms-edits' of github.com:metamelb-repliCATS/aggreCAT into ms-edits

# Conflicts:
#	.Rbuildignore
#	DESCRIPTION
#	inst/ms/aggreCAT.qmd
#	inst/ms/aggreCAT.tex
@egouldo egouldo merged commit edf6ecc into master Mar 31, 2023
@egouldo egouldo deleted the ms-edits branch March 31, 2023 04:33
@egouldo
Copy link
Member Author

egouldo commented Mar 31, 2023

FUCK YEAH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants