Prow: Use latest CRDs #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRDs were pinned because of an upstream issue. It has been solved, so we can go back to using the latest. The upstream issue is documented here: kubernetes-sigs/prow#181 Signed-off-by: Lennart Jern <[email protected]>
metal3-io-bot
added
the
size/XS
lentzi90
force-pushed
the
lentzi90/un-pin-prow-crds
branch
from
a1a7289 to
91269d6
Compare
|
/override metal3-ubuntu-e2e-integration-test-main |
|
@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRDs were pinned because of an upstream issue. It has been solved, so we can go back to using the latest.
The upstream issue is documented here: kubernetes-sigs/prow#181
I have updated the CRDs in the cluster also.
For the future we should also come up with a system for keeping them up to date. For example, update the CRDs every time we bump the images.