-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add custom ref input to container build workflow #927
🌱 Add custom ref input to container build workflow #927
Conversation
84223ff
to
5fa4898
Compare
This is needed to enable container image builds from tags via automated release workflow. Second step is amending metal3-io/ip-address-manager#775 to pass these inputs, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits about bash snippets. Let's start formatting those properly, makes life easier.
Otherwise, looks ok.
Signed-off-by: Huy Mai <[email protected]>
5fa4898
to
65f8d16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override metal3-ubuntu-e2e-integration-test-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds a custom inputs, which can be used to pass a custom git ref to the container build workflow. ref_name and sha references will be updated accordingly.
In case the input is not available, the workflow still uses
github.ref
github.ref_name
andgithub.sha
, which is the current behavior.