Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add custom ref input to container build workflow #927

Merged

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 9, 2024

This PR adds a custom inputs, which can be used to pass a custom git ref to the container build workflow. ref_name and sha references will be updated accordingly.
In case the input is not available, the workflow still uses github.ref github.ref_name and github.sha, which is the current behavior.

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-custom-ref-container-build-wf branch from 84223ff to 5fa4898 Compare December 9, 2024 09:51
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2024
@tuminoid
Copy link
Member

tuminoid commented Dec 9, 2024

This is needed to enable container image builds from tags via automated release workflow.

Second step is amending metal3-io/ip-address-manager#775 to pass these inputs, right?

@mquhuy
Copy link
Member Author

mquhuy commented Dec 10, 2024

/cc @lentzi90 @Rozzii @smoshiur1237

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits about bash snippets. Let's start formatting those properly, makes life easier.

Otherwise, looks ok.

.github/workflows/container-image-build.yml Outdated Show resolved Hide resolved
.github/workflows/container-image-build.yml Outdated Show resolved Hide resolved
.github/workflows/container-image-build.yml Outdated Show resolved Hide resolved
.github/workflows/container-image-build.yml Outdated Show resolved Hide resolved
.github/workflows/container-image-build.yml Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-custom-ref-container-build-wf branch from 5fa4898 to 65f8d16 Compare December 10, 2024 06:55
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 49bbcb0 into metal3-io:main Dec 10, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-custom-ref-container-build-wf branch December 10, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants