Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for ironic-image release-27.0 #919

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add configuration for ironic-image release-27.0 #919

merged 1 commit into from
Nov 27, 2024

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Nov 27, 2024 •
edited
Loading

No description provided.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2024
@elfosardo elfosardo force-pushed the ironic-image-release-270 branch from 9b219ca to 517ac4a Compare November 27, 2024 09:41
@elfosardo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-release-1-8 metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

nvm on the tests, not actually changing anything there, will test in the ironic-image branch

@elfosardo
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-release-1-8 metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@elfosardo: elfosardo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-ubuntu-e2e-integration-test-release-1-8 metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-release-1-8 metal3-ubuntu-e2e-integration-test-main

These mean nothing here.

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-release-1-8

In response to this:

/override metal3-ubuntu-e2e-integration-test-release-1-8 metal3-ubuntu-e2e-integration-test-main

These mean nothing here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you split removing and adding versions to their own PRs? Cleaner that way.

Also, technically 24.0 is still being tested as part of 1.6 release series, so it will be removed alongside with 1.6 series when 1.9 is cut.

@elfosardo elfosardo force-pushed the ironic-image-release-270 branch from 517ac4a to 0628765 Compare November 27, 2024 09:56
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2024
tuminoid
tuminoid reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@metal3-io-bot metal3-io-bot merged commit 601e198 into metal3-io:main Nov 27, 2024
6 checks passed
@metal3-io-bot
Copy link
Collaborator

@elfosardo: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key ironic-image-release-27.0.yaml using file prow/config/jobs/metal3-io/ironic-image-release-27.0.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfosardo @metal3-io-bot @tuminoid