Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: Fix commenter and checkconfig command #590

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

lentzi90
Copy link
Member

We have prow jobs that fail with

{"component":"entrypoint","error":"could not start the process: fork/exec /app/robots/commenter/app.binary: no such file or directory","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2023-10-24T17:46:51Z"}

There was a change in upstream that we missed when bumping the image tags.
See https://github.com/kubernetes/test-infra/pull/25384/files

@lentzi90 lentzi90 changed the title Prow: Fix commenter command Prow: Fix commenter and checkconfig command Oct 24, 2023
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@lentzi90
Copy link
Member Author

/test check-prow-config

@lentzi90
Copy link
Member Author

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@smoshiur1237
Copy link
Member

smoshiur1237 commented Oct 24, 2023

Good catch, how did we miss it?

@lentzi90
Copy link
Member Author

The check-prow-config that run on the PR that changed the image tags did not use the new image 😅
Then we have just not checked the periodic stale jobs. We should probably add some alerting for that

@lentzi90
Copy link
Member Author

I have applied this in the cluster now (that is why the second check-prow-config was successful)

@lentzi90
Copy link
Member Author

I'm going to self approve this since it is such a small change and prow is broken without it
/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@metal3-io-bot metal3-io-bot merged commit 71fd610 into metal3-io:main Oct 24, 2023
2 checks passed
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

We have prow jobs that fail with

{"component":"entrypoint","error":"could not start the process: fork/exec /app/robots/commenter/app.binary: no such file or directory","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2023-10-24T17:46:51Z"}

There was a change in upstream that we missed when bumping the image tags.
See https://github.com/kubernetes/test-infra/pull/25384/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90 lentzi90 deleted the lentzi90/prow-command-change branch October 24, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants