-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow: Fix commenter and checkconfig command #590
Prow: Fix commenter and checkconfig command #590
Conversation
/test check-prow-config |
/override test-ubuntu-integration-main |
@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Good catch, how did we miss it? |
The check-prow-config that run on the PR that changed the image tags did not use the new image 😅 |
I have applied this in the cluster now (that is why the second check-prow-config was successful) |
I'm going to self approve this since it is such a small change and prow is broken without it |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lentzi90: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We have prow jobs that fail with
There was a change in upstream that we missed when bumping the image tags.
See https://github.com/kubernetes/test-infra/pull/25384/files