Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck runmariadb script #32

Merged

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 9, 2025

Shellcheck only looks for '*.sh' files, runmariadb script doesn't have the necessary suffix to be detected. Add it explicitly to be checked.

Shellcheck only looks for '*.sh' files, runmariadb script doesn't have
the necessary suffix to be detected. Add it explicitly to be checked.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2025

/cc @dtantsur

I will also need to fix it on project-infra side. I'll link that PR here soon.

edit: metal3-io/project-infra#946

@metal3-io-bot metal3-io-bot requested a review from dtantsur January 9, 2025 14:08
@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2025

/hold
Project-infra PR needs to go in first, so we can see if this triggers on the current script (it does not, but good to get CI to agree).

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@dtantsur
Copy link
Member

dtantsur commented Jan 9, 2025

/approve
/override metal3-ubuntu-e2e-integration-test-main

Thanks!

@metal3-io-bot
Copy link
Contributor

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-ubuntu-e2e-integration-test-main

In response to this:

/approve
/override metal3-ubuntu-e2e-integration-test-main

Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@tuminoid
Copy link
Member Author

OK, project-infra change is merged, let's try it out.

/test shellcheck

@tuminoid
Copy link
Member Author

No issues found in runmariadb script, so
/unhold

/cc @kashifest @lentzi90

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@metal3-io-bot metal3-io-bot merged commit e01715f into metal3-io:main Jan 13, 2025
4 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/shellcheck-also-runmariadb branch January 13, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants