-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shellcheck runmariadb script #32
shellcheck runmariadb script #32
Conversation
Shellcheck only looks for '*.sh' files, runmariadb script doesn't have the necessary suffix to be detected. Add it explicitly to be checked. Signed-off-by: Tuomo Tanskanen <[email protected]>
/cc @dtantsur I will also need to fix it on project-infra side. I'll link that PR here soon. |
/hold |
/approve Thanks! |
@dtantsur: Overrode contexts on behalf of dtantsur: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK, project-infra change is merged, let's try it out. /test shellcheck |
No issues found in runmariadb script, so /cc @kashifest @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Shellcheck only looks for '*.sh' files, runmariadb script doesn't have the necessary suffix to be detected. Add it explicitly to be checked.