Clean up many prereqs #1230
Merged
Clean up many prereqs #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
reviewed
Jun 19, 2024
haarg
force-pushed
the
haarg/cleanup-deps
branch
5 times, most recently
from
220e61d to
9e4be13
Compare
|
Looks like it wants |
haarg
force-pushed
the
haarg/cleanup-deps
branch
from
9e4be13 to
ba2770c
Compare
mickeyn
previously approved these changes
Jun 29, 2024
Test::Exception has too much magic.
Test::Most just obscures what is being used.
We use DateTime::Format::ISO8601 elsewhere for parsing dates, so also used it in the latest script. This makes the comparison used more obvious, and removes use of both Regexp::Common::time and Time::Local.
Rather than implementing the OAuth2 controller as a plugin that injects a controller, just make it a normal controller. This accomplishes the same thing but is simpler.
Git::Helpers has a bunch of prereqs and provides many functions, when the only thing we need is checkout_root. That is trivial to implement ourselves. In the future, we're likely to not even need the sub anymore.
We don't declare a dependency on Data::Printer, but had a module using it. It was only used for logging, but Log::Contextual already has functions for printing data structures which we can use instead.
The tests had multiple ways to do a simple HTTP request against the app. We don't need that. Removing one of them removes multiple modules and prereqs.
IO::Interactive tries to generalize the concept of "interactivity", but we don't actually want the general concept. Color log output should be based on if STDERR is connected to a terminal. And skipping a prompt should be based on STDIN.
We don't need any of IO::Prompt's extra features or its weird behaviors and prereqs.
XML::Simple is not recommended because it is hard to use correctly. We can use XML::XPath instead, and the code is actually simpler.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
- Coverage 60.81% 60.75% -0.07%
==========================================
Files 163 163
Lines 4453 4441 -12
Branches 646 646
==========================================
- Hits 2708 2698 -10
+ Misses 1512 1510 -2
Partials 233 233
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a bunch of unused prereqs.
Also replace some prereqs with simpler variants.