Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop some unneeded prereqs #1222

Merged
merged 1 commit into from
May 19, 2024
Merged

drop some unneeded prereqs #1222

merged 1 commit into from
May 19, 2024

Conversation

haarg
Copy link
Member

@haarg haarg commented May 19, 2024

Some of the prereqs are from old removed code, and others are trivially replaced with more standard modules.

mickeyn
mickeyn previously approved these changes May 19, 2024
Some of the prereqs are from old removed code, and others are trivially
replaced with more standard modules.
@haarg haarg force-pushed the haarg/less-prereqs branch from 230055c to 6a2c163 Compare May 19, 2024 18:20
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.74%. Comparing base (00bc1ad) to head (6a2c163).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   60.75%   60.74%   -0.01%     
==========================================
  Files         163      163              
  Lines        4457     4456       -1     
  Branches      649      649              
==========================================
- Hits         2708     2707       -1     
  Misses       1516     1516              
  Partials      233      233              
Files Coverage Δ
lib/MetaCPAN/Document/File.pm 89.36% <100.00%> (ø)
lib/MetaCPAN/Script/Tickets.pm 74.02% <100.00%> (+0.34%) ⬆️
lib/MetaCPAN/Server/Controller.pm 86.76% <ø> (-0.20%) ⬇️
lib/MetaCPAN/Script/Backup.pm 18.18% <0.00%> (-1.47%) ⬇️

@haarg haarg merged commit 75671c5 into master May 19, 2024
3 checks passed
@haarg haarg deleted the haarg/less-prereqs branch May 19, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants