Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

author import: handle duplicate ids #1180

Merged
merged 1 commit into from
Apr 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion lib/MetaCPAN/Script/Author.pm
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,49 @@ my @compare_fields = do {
sort grep !$seen{$_}++, @cpan_fields, @author_config_fields;
};

has whois_data => (
is => 'ro',
traits => ['NoGetopt'],
lazy => 1,
builder => '_build_whois_data',
);

sub _build_whois_data {
my $self = shift;
my $data = XMLin(
$self->author_fh,
ForceArray => 1,
SuppressEmpty => '',
NoAttr => 1,
KeyAttr => [],
);

my $whois_data = {};

for my $author ( @{ $data->{cpanid} } ) {
my $data = {
map {
my $content = $author->{$_};
@$content == 1
&& !ref $content->[0] ? ( $_ => $content->[0] ) : ();
} keys %$author
};

my $pauseid = $data->{id};
my $existing = $whois_data->{$pauseid};
if ( !$existing
|| $existing->{type} eq 'author' && $data->{type} eq 'list' )
{
$whois_data->{$pauseid} = $data;
}
}

return $whois_data;
}

sub index_authors {
my $self = shift;
my $authors = XMLin( $self->author_fh )->{cpanid};
my $authors = $self->whois_data;

if ( $self->pauseid ) {
log_info {"Indexing 1 author"};
Expand Down