Merge pull request #1236 from metacpan/haarg/fix-digest-calc

fix digest calculation from misuse or tr
metacpan · Jul 15, 2024 · d3fc66b · d3fc66b
2 parents b08ff6f + c3c8e15
commit d3fc66b
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 4 deletions.
diff --git a/lib/MetaCPAN/Server/Controller/CVE.pm b/lib/MetaCPAN/Server/Controller/CVE.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use MetaCPAN::Util qw( digest );
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 

diff --git a/lib/MetaCPAN/Server/Controller/Contributor.pm b/lib/MetaCPAN/Server/Controller/Contributor.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use MetaCPAN::Util qw( digest );
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 

diff --git a/lib/MetaCPAN/Server/Controller/Cover.pm b/lib/MetaCPAN/Server/Controller/Cover.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use MetaCPAN::Util qw( digest );
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 

diff --git a/lib/MetaCPAN/Util.pm b/lib/MetaCPAN/Util.pm
@@ -48,7 +48,7 @@ sub checkout_root {
 
 sub digest {
     my $digest = sha1_base64( join( "\0", grep {defined} @_ ) );
-    $digest =~ tr/[+\/]/-_/;
+    $digest =~ tr{+/}{-_};
     return $digest;
 }