Update to JSQLParser 5.0 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @crisptrutski and the rest of your teammates on |
crisptrutski
force-pushed
the
jsqlparser-5.0
branch
from
8c4b0e7
to
abe12ff
Compare
crisptrutski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Closes #73
This upgrades us to the latest JSQLParser, which fixes one of our fixtures.
Unfortunately it seems there is a bug in the tokens, they are giving off-by-one errors on their line, which was a real pain to discover after going down so many other rabbit holes. They also changed the scope of the Table node to include the alias, which was also quite annoying.
The new Visitor interfaces are really more Foldable / Traversibles, which is great - it means we can use them to make the completeness of our newer walkers statically verified, but I have not done that here yet.