CI: test libatomic #1784
Open
CI: test libatomic #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some platforms, libatomic is needed to be linked to use std::atomic or C atomics. This seems to be a way to test this. Signed-off-by: Rosen Penev <[email protected]>
Increase test coverage to extra architectures. Because most of these use QEMU, they are really slow. Thus, limit to sanity_checks. Signed-off-by: Rosen Penev <[email protected]>
It seems __sync_synchronize does not need libatomic. Test __atomic_is_lock_free instead. Signed-off-by: Rosen Penev <[email protected]>
|
actually it's enough to switch Alpine from x64 to x86 and g++ to clang to test atomic. @bgilbert what do you think? |
|
huh, PPC errors in abseil-cpp: Very interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.