Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrap files for Kraken-Engine-0.0.1 #1756

Closed
wants to merge 0 commits into from
Closed

Add wrap files for Kraken-Engine-0.0.1 #1756

wants to merge 0 commits into from

Conversation

durkisneer1
Copy link
Contributor

No description provided.

@durkisneer1
Copy link
Contributor Author

I've been forgotten 😔

@jpakkane
Copy link
Member

You need to rebase against current master to make the error go away.

@durkisneer1
Copy link
Contributor Author

Got it, thanks. There were no errors with the sanity checks on my local system with VS and MingW so hopefully the next workflow pass doesn't also fail.

@jpakkane
Copy link
Member

You used a merge. Those are not allowed because they screw up history. Convert it to a rebase instead. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durkisneer1 @jpakkane