Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volk: Add wrap #1504

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

volk: Add wrap #1504

wants to merge 1 commit into from

Conversation

antoniovazquezblanco
Copy link
Contributor

No description provided.

@antoniovazquezblanco antoniovazquezblanco marked this pull request as draft May 6, 2024 12:42
eli-schwartz
eli-schwartz requested changes May 6, 2024
View reviewed changes
subprojects/volk.wrap
source_url = https://github.com/gnuradio/volk/releases/download/v3.1.2/volk-3.1.2.tar.xz
source_filename = volk-3.1.2.tar.xz
source_hash = ce62f645c2ee3ef8b38f923de78ef4df9a1b7696d618f57781955803ee29bab3
method = cmake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapdb can't use cmake, it has to be a native meson build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Marked as draft until I find the time to properly rewrite the build system stuff in meson...

@antoniovazquezblanco
Copy link
Contributor Author

@eli-schwartz, I have a doubt. This build requires Python Mako. I was able to provide that dependency via ci_config.json but many package managers do not provide python packages. How can I provide that in Windows (via chocolatey) or in Mac OS (via brew)?

Thanks

@neheb
Copy link
Collaborator

neheb commented May 6, 2024

I think @bgilbert worked on a commit adding pip package support.

@bgilbert
Copy link
Contributor

bgilbert commented May 6, 2024

Yes, it was #1481. I could resurrect that PR if desired.

@antoniovazquezblanco
Copy link
Contributor Author

It will take me a long while until I find the time to redo this in meson. I believe there is zero rush in reviving that. It was to know if this was thought or not.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoniovazquezblanco @neheb @bgilbert @eli-schwartz