lua: Only build as DLL on Windows #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-DLUA_BUILD_AS_DLL` was being applied to all non-POSIX platforms rather than only Windows.
|
You should have added a new entry to |
|
Ah, given this PR has already been merged do I create a new one to bump it? |
|
Oops, missed that indeed, yes please make another PR. |
|
It also means that CI did not run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DLUA_BUILD_AS_DLLwas being applied to all non-POSIX platforms rather than only Windows, this would lead to__declspec(dllexport)/__declspec(dllimport)being used which is Windows-specific causing compilation to fail on non-Windows platforms.