Commits on Oct 31, 2024

1. Revert "meson: De-dup rpath arguments" …

   This reverts commit 8242187.
   
   This same change was previously introduced in mesonbuild#12495 / commit
   30ab974 and subsequently reverted
   in mesonbuild#12672 / commit 2fbc7b5
   
   Reintroduced in mesonbuild#13819 but it's still the same old problem. To repeat
   the problem:
   
   This breaks at least:
   - frameworks/17 mpi
   - frameworks/30 scalapack
   
   The problem is that openmpi's pkg-config emitted link arguments
   includes:
   
   ```
   -Wl,-rpath -Wl,/path/to/libdir
   ```
   
   The deduplication logic in meson doesn't contain sufficient information
   to tell when the compiler is passing an argument that requires values,
   and definitely cannot tell when that argument is split across argv. But
   for arguments that *can* do this, it is not possible to deduplicate a
   single argument as standalone, because it is not standalone.
   
   The argument for deduplicating rpath here was that if you have multiple
   dependencies that all add the same rpath, the Apple ld64 emits a
   non-fatal warning "duplicate -rpath ignored". Since this is non-fatal,
   it's not a major issue. A major issue is when builds fatally error out
   with:
   
   ```
   FAILED: scalapack_c
   cc  -o scalapack_c scalapack_c.p/main.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--start-group /usr/lib64/libscalapack.so /usr/lib64/liblapack.so /usr/lib64/libblas.so -Wl,-rpath -Wl,/usr/lib64 -Wl,/usr/lib64 -Wl,--enable-new-dtags /usr/lib64/libmpi.so -Wl,--end-group
   /usr/libexec/gcc/x86_64-pc-linux-gnu/ld: error: /usr/lib64: read: Is a directory
   ```
   
   Today we have CI for this so the change actually caused our own unittest
   CI to go red.

   

   eli-schwartz committed Oct 31, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6091ef0
   • Browse repository at this point

   Copy the full SHA

   6091ef0 View commit details

   Browse the repository at this point in the history