Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gir gst regression #13837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bruchar1
Copy link
Member

No description provided.

@bruchar1 bruchar1 force-pushed the gir-gst-regression branch 2 times, most recently from 5de578f to 5b72845 Compare October 30, 2024 13:41
@bruchar1 bruchar1 marked this pull request as ready for review October 30, 2024 13:41
@bruchar1 bruchar1 added this to the 1.6.1 milestone Oct 30, 2024
@xclaesse
Copy link
Member

@bruchar1 while I agree this fix this case, that means we need to do that in every single place we do isinstance(lib, build.SharedLibrary) in the whole Meson codebase. This is why I originally made BothLibraries subclass SharedLibrary. That got changed against my recommendation.

@xclaesse
Copy link
Member

I think BothLibraries should exclusively be an interpreter concept. It's already a big mistake to even have that class in build.py, it should be an InterpreterObject inside interpreterobjects.py.

In build.py we need 2 classes (naming TBD):

class SharedLibraryWithStatic(SharedLibrary):
  def as_static(self):
    return self.static
class StaticLibraryWithShared(StaticLibrary):
  def as_shared(self):
    return self.shared

That way we are sure they are treaded exactly as a shared/static library everywhere, but we still can take their bother library for the specific case of as_shared() and as_static() methods.

@xclaesse
Copy link
Member

@bruchar1 I made an alternative implementation in #13835. What do you think?

@bruchar1
Copy link
Member Author

bruchar1 commented Nov 5, 2024

@bruchar1 I made an alternative implementation in #13835. What do you think?

I like the idea. I'm trying to fix it here, since I cannot write to your branch...

@bruchar1 bruchar1 force-pushed the gir-gst-regression branch 2 times, most recently from 8c45fe7 to 581ec17 Compare November 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants